This repository was archived by the owner on Oct 4, 2021. It is now read-only.
Fixes VSTS Bug 668301: [Feedback] Unable to change font colors for #5839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
reviewed
Sep 3, 2018
|
|
||
| public static bool IsCompileableFile (MonoDevelop.Projects.Project p, ProjectFile file, out Microsoft.CodeAnalysis.SourceCodeKind sck) | ||
| { | ||
| var ext = file.FilePath.Extension; |
Contributor
There was a problem hiding this comment.
can we move this into the if below?
Therzok
reviewed
Sep 3, 2018
| base.Dispose (); | ||
| workspace.CloseDocument (documentId); | ||
| DocumentContext.AnalysisDocumentChanged += delegate { | ||
| Editor.SyntaxHighlighting = new RoslynClassificationHighlighting ( |
Contributor
There was a problem hiding this comment.
Should we recreate the highlighting every time we parse a document?
Contributor
|
Also fixes #4036 |
Contributor
|
Alternative fix: #5840 |
Contributor
Author
mkrueger
force-pushed
the
master-vsts668301
branch
from
6d77227 to
1796b08
Compare
DavidKarlas
approved these changes
Sep 4, 2018
slluis
reviewed
Sep 4, 2018
| public static bool IsCompileableFile (ProjectFile file, out Microsoft.CodeAnalysis.SourceCodeKind sck) | ||
| => IsCompileableFile (null, file, out sck); | ||
|
|
||
| public static bool IsCompileableFile (MonoDevelop.Projects.Project p, ProjectFile file, out Microsoft.CodeAnalysis.SourceCodeKind sck) |
Member
There was a problem hiding this comment.
There is already an IsCompileable method in the Project class. SourceCodeKind could just be a property of ProjectFile.
Therzok
approved these changes
Sep 12, 2018
vb.net by Visual Studio Community 2017 for Mac https://devdiv.visualstudio.com/DevDiv/_workitems/edit/668301 Basically using the former roslyn classification highlighting (latest version). However the vb.net loading gets implemented in our workspace system so the old hack could go away. Switching to tag based highlighting should work when the editorfeatures.vbnet dll can be added to our mef composition. But for now that re-enables vb.net coloring.
…ual Studio Community 2017 for Mac
mkrueger
force-pushed
the
master-vsts668301
branch
from
29ca43c to
56cde02
Compare
node helper method.
Therzok
reviewed
Sep 12, 2018
| => IsCompileableFile (null, file, out sck); | ||
|
|
||
| [Obsolete ("Use p.IsCompileable")] | ||
| public static bool IsCompileableFile (MonoDevelop.Projects.Project p, ProjectFile file, out Microsoft.CodeAnalysis.SourceCodeKind sck) |
Contributor
There was a problem hiding this comment.
Don't add a new obsolete method.
Contributor
Author
There was a problem hiding this comment.
Why ? it is obsolete now.
Member
There was a problem hiding this comment.
There is no point in adding a new obsolete method because nobody is going to use it.
Contributor
Author
There was a problem hiding this comment.
Ah sry misread - the 'add obsolete' method :) - y there is no point in it - true.
slluis
reviewed
Sep 12, 2018
| Project.NotifyFilePropertyChangedInProject (this, property); | ||
| } | ||
|
|
||
| public virtual SourceCodeKind SourceCodeKind { |
Member
There was a problem hiding this comment.
Please don't make this method virtual.
Member
|
@monojenkins backport release-7.6 |
Contributor
|
@slluis backporting to release-7.6 failed, the patch results in conflicts: Please backport manually! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vb.net by Visual Studio Community 2017 for Mac
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/668301
Basically using the former roslyn classification highlighting (latest
version). However the vb.net loading gets implemented in our workspace
system so the old hack could go away.
Switching to tag based highlighting should work when the
editorfeatures.vbnet dll can be added to our mef composition. But for
now that re-enables vb.net coloring.