Skip to content
This repository was archived by the owner on Oct 4, 2021. It is now read-only.

Conversation

@iainx
Copy link
Contributor

@iainx iainx commented Sep 20, 2018

fixes VSTS #678313

@iainx iainx requested a review from slluis as a code owner September 20, 2018 14:03
@iainx iainx requested review from Therzok and mrward September 20, 2018 14:03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing is off

@slluis
Copy link
Member

slluis commented Sep 24, 2018

The RestartRequested property should also be set when restarting VSMac because of the updater. I don't think the Restart method is called in this case.

} else if (IdeApp.IsInitialRun) {
startupType = StartupType.FirstLaunch;
} else if (Debugger.IsAttached) {
startupType = StartupType.LaunchedAsDebugger;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think LaunchedAsDebugger applies to VSMac. On Windows this happens when an application crashes and the debug button is clicked on the crash dialog. This is unrelated to the VSMac process being debugged or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could be debugging a bundle via Debug Application.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worth taking these out as they skew results

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I meant DebuggerPresent not LaunchedAsDebugger

@iainx iainx merged commit 22b44ce into master Sep 28, 2018
@iainx
Copy link
Contributor Author

iainx commented Sep 28, 2018

@monojenkins backport release-7.6

@iainx
Copy link
Contributor Author

iainx commented Sep 28, 2018

@monojenkins backport release-7.7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants