-
Notifications
You must be signed in to change notification settings - Fork 1k
[Telemetry] Add the correct StartupType values for the startup event #6051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing is off
fixes VSTS #678313
|
The RestartRequested property should also be set when restarting VSMac because of the updater. I don't think the Restart method is called in this case. |
| } else if (IdeApp.IsInitialRun) { | ||
| startupType = StartupType.FirstLaunch; | ||
| } else if (Debugger.IsAttached) { | ||
| startupType = StartupType.LaunchedAsDebugger; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think LaunchedAsDebugger applies to VSMac. On Windows this happens when an application crashes and the debug button is clicked on the crash dialog. This is unrelated to the VSMac process being debugged or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could be debugging a bundle via Debug Application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth taking these out as they skew results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I meant DebuggerPresent not LaunchedAsDebugger
|
@monojenkins backport release-7.6 |
|
@monojenkins backport release-7.7 |
fixes VSTS #678313