This repository was archived by the owner on Oct 4, 2021. It is now read-only.
Allow selection of browser for ASP.NET Core projects#8234
Merged
Conversation
mrward
reviewed
Jul 19, 2019
Contributor
mrward
left a comment
mrward
left a comment
There was a problem hiding this comment.
Everything else looks good to me.
main/src/addins/MonoDevelop.AspNetCore/MonoDevelop.AspNetCore/AspNetCoreExecutionCommand.cs
Outdated
Show resolved
Hide resolved
main/src/addins/MonoDevelop.AspNetCore/MonoDevelop.AspNetCore/AspNetCoreProjectExtension.cs
Show resolved
Hide resolved
slluis
suggested changes
Jul 19, 2019
main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore/DotNetCoreExecutionCommand.cs
Outdated
Show resolved
Hide resolved
Therzok
reviewed
Jul 19, 2019
main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore/DotNetCoreExecutionCommand.cs
Outdated
Show resolved
Hide resolved
Therzok
reviewed
Jul 19, 2019
Therzok
reviewed
Jul 19, 2019
Therzok
reviewed
Jul 19, 2019
main/src/addins/MonoDevelop.AspNetCore/MonoDevelop.AspNetCore/AspNetCoreExecutionHandler.cs
Outdated
Show resolved
Hide resolved
rodrmoya
force-pushed
the
pr-select-browser
branch
from
8609a42 to
e887e9e
Compare
Therzok
reviewed
Jul 19, 2019
main/src/addins/MonoDevelop.AspNetCore/MonoDevelop.AspNetCore/AspNetCoreExecutionHandler.cs
Show resolved
Hide resolved
mrward
approved these changes
Jul 19, 2019
Member
|
It looks good now. We need test scenarios though. |
jtorres
approved these changes
Jul 19, 2019
nosami
approved these changes
Jul 19, 2019
Therzok
approved these changes
Jul 19, 2019
rodrmoya
force-pushed
the
pr-select-browser
branch
from
5f74c46 to
ac78ff2
Compare
rodrmoya
force-pushed
the
pr-select-browser
branch
3 times, most recently
from
226d1bd to
da88ede
Compare
added 5 commits
July 25, 2019 11:31
Also, remove some old CoreFoundation bindings which are not needed anymore, as same code is available in Xamarin.Mac already.
Instead of duplicating code, just make the ExecutionHandler's call the specific Command implementation of its PostLaunch logic.
And move it to the ExecutionHandler's, as before
Co-Authored-By: Marius Ungureanu <marius.ungureanu@xamarin.com>
rodrmoya
force-pushed
the
pr-select-browser
branch
from
da88ede to
3f51da1
Compare
rodrmoya
force-pushed
the
pr-select-browser
branch
from
3f51da1 to
b03c1c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/669198