Skip to content
This repository was archived by the owner on Oct 4, 2021. It is now read-only.

[IDE] Bypass Focus Document if the current document is already focused#995

Closed
iainx wants to merge 1 commit intomono:masterfrom
iainx:fix-29887
Closed

[IDE] Bypass Focus Document if the current document is already focused#995
iainx wants to merge 1 commit intomono:masterfrom
iainx:fix-29887

Conversation

@iainx
Copy link
Copy Markdown
Contributor

@iainx iainx commented Jul 30, 2015

If we bypass the Focus Document command when the current document is already focused
then the keypress is passed on down the event chain

Would it be better to implement a more generic system with the command manager asking the focused widget if it wants to handle a keypress before passing it to command dispatch, or will just just make the whole system more complicated than it needs to be?

Fixes BXC #29887

If we bypass the Focus Document command when the current document is already focused
then the keypress is passed on down the event chain

Fixes BXC #29887
@slluis
Copy link
Copy Markdown
Member

slluis commented Jul 31, 2015

This is a tricky one. Even if the patch fixes the problem, it is a very specific fix, only for that use case. The real fix would be to give a chance to the widget to handle the key press, but this would make the command manager much more complex, and might have unwanted side effects. In my opinion, if the user redefines a key binding, it should be redefined to all extents, no matter if a widget handles it or not.

@iainx iainx mentioned this pull request Jul 31, 2015
@iainx iainx closed this Aug 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants