This repository was archived by the owner on Oct 4, 2021. It is now read-only.
[IDE] Bypass Focus Document if the current document is already focused#995
Closed
iainx wants to merge 1 commit intomono:masterfrom
Closed
[IDE] Bypass Focus Document if the current document is already focused#995iainx wants to merge 1 commit intomono:masterfrom
iainx wants to merge 1 commit intomono:masterfrom
Conversation
If we bypass the Focus Document command when the current document is already focused then the keypress is passed on down the event chain Fixes BXC #29887
Member
|
This is a tricky one. Even if the patch fixes the problem, it is a very specific fix, only for that use case. The real fix would be to give a chance to the widget to handle the key press, but this would make the command manager much more complex, and might have unwanted side effects. In my opinion, if the user redefines a key binding, it should be redefined to all extents, no matter if a widget handles it or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we bypass the Focus Document command when the current document is already focused
then the keypress is passed on down the event chain
Would it be better to implement a more generic system with the command manager asking the focused widget if it wants to handle a keypress before passing it to command dispatch, or will just just make the whole system more complicated than it needs to be?
Fixes BXC #29887