Skip to content

Optimize chat recomposition with Compose stability config and stable callbacks#172

Merged
gdlbo merged 2 commits intodevelopfrom
compose-recompilation-fixes
Apr 5, 2026
Merged

Optimize chat recomposition with Compose stability config and stable callbacks#172
gdlbo merged 2 commits intodevelopfrom
compose-recompilation-fixes

Conversation

@gdlbo
Copy link
Copy Markdown
Member

@gdlbo gdlbo commented Apr 4, 2026

No description provided.

@gdlbo gdlbo requested a review from RecodeLiner April 4, 2026 17:40
@gdlbo gdlbo marked this pull request as draft April 5, 2026 02:14
@gdlbo gdlbo marked this pull request as ready for review April 5, 2026 10:03
@RecodeLiner
Copy link
Copy Markdown
Collaborator

  1. full exclude presentation's models from stability conf, you already annotated them with stable and immutable

@RecodeLiner
Copy link
Copy Markdown
Collaborator

  1. if (!minithumbnail.contentEquals(other.minithumbnail)) return false

better to use
if (!(minithumbnail contentEquals other.minithumbnail)) return false

or even
if (!minithumbnail.contentEquals(other.minithumbnail) &&
!(minithumbnail == null && other.minithumbnail == null)) return false

@RecodeLiner
Copy link
Copy Markdown
Collaborator

  1. message_thread_id (ref. MessageModel.threadId) in tdlib doc has type int53. Basic kotlin int only 32-bit, better to use long

@RecodeLiner
Copy link
Copy Markdown
Collaborator

ReactionSender, BotCommandModel, BotCommandModel, ChatPermissionsModel, UserModel - all stable

This removes redundant stability config entries, adds @stable annotations for domain models, and updates message thread IDs to Long with null-safe contentEquals checks.
@gdlbo gdlbo merged commit fb70099 into develop Apr 5, 2026
@gdlbo gdlbo deleted the compose-recompilation-fixes branch April 5, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants