Skip to content

Add build instructions for libvpx#173

Merged
gdlbo merged 1 commit intomonogram-android:developfrom
curtisy1:docs-update
Apr 4, 2026
Merged

Add build instructions for libvpx#173
gdlbo merged 1 commit intomonogram-android:developfrom
curtisy1:docs-update

Conversation

@curtisy1
Copy link
Copy Markdown
Contributor

@curtisy1 curtisy1 commented Apr 4, 2026

For a first time installation on develop, recurse submodules is necessary, on top of building libvpx. Otherwise, building the app will fail.

Add a paragraph to address this

For a first time installation on develop, recurse submodules is necessary, on top of building libvpx. Otherwise, building the app will fail.

Add a paragraph to address this
@gdlbo
Copy link
Copy Markdown
Member

gdlbo commented Apr 4, 2026

Maybe it would be better to do it as a Gradle script?

@curtisy1
Copy link
Copy Markdown
Contributor Author

curtisy1 commented Apr 4, 2026

Good idea. I'll close this and spin up a new PR adding this into a Gradle script.
Do you prefer keeping the build.sh file or should I move the logic to Gradle entirely? Personally, I'd lean towards keeping it in bash to avoid cluttering the gradle file

@aliveoutside
Copy link
Copy Markdown
Collaborator

Maybe it would be better to do it as a Gradle script?

Strong disagree. Just keep git clone --recurse-submodules in README. Don't break separation of concerns

@gdlbo gdlbo merged commit ee55a8b into monogram-android:develop Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants