Remove incorrect zipcodes #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodyhoskins
approved these changes
Nov 16, 2024
Collaborator
brodyhoskins
left a comment
brodyhoskins
left a comment
There was a problem hiding this comment.
Great catch, I've confirmed the removals are valid. Thank you!
Contributor
Author
|
Happy to help! This gem saved us so much trouble! I think there's one zip code in Texas that is valid (and is in the source code) but somehow seems to be being rejected as invalid Will see if I can dig further and open another request in the next week or so |
Contributor
Author
|
@brodyhoskins It turns out it wasn't in the source code; I messed up using github search. I opened a new PR to add it here #47 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for providing this gem it's really beneficial for zip sense checks!
I've noticed 4 invalid zip codes are returning as if they are valid.
If USPS is not considered the true authority on zip validity for this gems purposes, please feel free to close out this PR
Thank you
46983
27838
29077
75286