Feat: Buffer Implementation#31
Merged
Merged
Conversation
… to stream metrics to the server
&& refactor collectors accordingly
&& update scheduler to use it
…ptr of series buffers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new metrics buffering system and introduces a
DeviceIDtagging system. The main changes include implementing thebuffer.h/buffer.ccsystem for efficient metrics storage and updating all collectors to use the newDeviceIDtype.Metrics Buffering System:
SeriesBufferandMetricsBufferclasses inbuffer.h/buffer.ccto efficiently store and manage time-series metric samples, including thread-safe access and snapshotting. [1] [2]MetricsBuffermapsMetricTypeandDeviceIDcombination to a correspondingSeriesBuffer.SeriesBufferholds a ring buffer ofSamples as well as write and read markers. It enables pushing new samples, getting a snapshot of unread metrics and acking the snapshot to advance the read marker.DeviceIDtaggingMetricstruct was updated to include adeviceIdfield that identifies the device that a measurement was performed on.MetricTypeandDeviceIDidentifies metrics.These changes enhance the flexibility, correctness, and maintainability of the agent's metrics collection and buffering infrastructure.