Load NVML at runtime via dlopen#33
Merged
Merged
Conversation
patryk-przybysz
requested review from
FW-Nagorko and
varev-dev
and removed request for
FW-Nagorko
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the agent resolves NVML at compile time: CMake either links
libnvidia-mldirectly or falls back to a compile-time stub that fakes GPU metrics. That means the binary's behaviour depends on what was present when it was built, not what's on the host at runtime and we can't ship one artifact to mixed GPU/non-GPU machines without awkward build-time branching.This PR loads NVML lazily at runtime via
dlopen/dlsymin a newplatform/nvml_loadermodule.NvmlCollectorcalls NVML through a function-pointer table; if the library isn't present, the collector is simply unsupported.Verification
Tested on WSL, please check on a native Linux machine with an NVIDIA GPU before merging