Skip to content

🐛 [NO-TICKET] Migrate scroll to last item#15

Open
MCR19 wants to merge 2 commits intomasterfrom
fix/NO-TICKET-migrate-scroll-to-last-item
Open

🐛 [NO-TICKET] Migrate scroll to last item#15
MCR19 wants to merge 2 commits intomasterfrom
fix/NO-TICKET-migrate-scroll-to-last-item

Conversation

@MCR19
Copy link
Copy Markdown

@MCR19 MCR19 commented Dec 12, 2022

This PR migrates recent scrollToLastItem fixes in MessageKit. This is to fix crashes when the MessagesCollectionView tries to scroll to the last item in the collection view and the collection view is either still in a layout or reload cycle.

The first fix was added here, previous scroll logic was deprecated here and then finally improved here

Here's the MessageKit changelog for reference

@timmikeljmonzo
Copy link
Copy Markdown

Did you have a chance to test this @MCR19?

@timmikeljmonzo
Copy link
Copy Markdown

did you just cherry pick those changes from main MessageKit repo out of interest?

@MCR19
Copy link
Copy Markdown
Author

MCR19 commented Dec 13, 2022

Did you have a chance to test this @MCR19?

I have @timmikeljmonzo and looks to be working as expected. The scrolling to the beginning of the chat issue is tricky to replicate so will likely have to ask the customer experiencing the issue to confirm any fixes.

I'm also planning to put any changes behind a feature flag.

@MCR19
Copy link
Copy Markdown
Author

MCR19 commented Dec 13, 2022

did you just cherry pick those changes from main MessageKit repo out of interest?

I didn't no, as the logic I wanted was split over multiple commits. There is also changes in some of the commits that we don't support in our fork. Would it be better for me to cherry pick them?

@timmikeljmonzo timmikeljmonzo removed their request for review May 19, 2023 09:01
@timmikeljmonzo timmikeljmonzo removed their assignment May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants