Open
Conversation
|
Did you have a chance to test this @MCR19? |
|
did you just cherry pick those changes from main MessageKit repo out of interest? |
Author
I have @timmikeljmonzo and looks to be working as expected. The scrolling to the beginning of the chat issue is tricky to replicate so will likely have to ask the customer experiencing the issue to confirm any fixes. I'm also planning to put any changes behind a feature flag. |
Author
I didn't no, as the logic I wanted was split over multiple commits. There is also changes in some of the commits that we don't support in our fork. Would it be better for me to cherry pick them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates recent
scrollToLastItemfixes inMessageKit. This is to fix crashes when theMessagesCollectionViewtries to scroll to the last item in the collection view and the collection view is either still in a layout or reload cycle.The first fix was added here, previous scroll logic was deprecated here and then finally improved here
Here's the MessageKit changelog for reference