Fix link checker on Windows #1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Before this change the way links formed differed based on operating system. This meant that on Windows the fix-renamed links checker would both change links that it should not, and leave them with Windows style slashes.
NeillM
force-pushed
the
fixlinkchecker
branch
from
941c431 to
a7138a6
Compare
Contributor
⚡️ Lighthouse report for the deploy preview of this PR
|
andrewnicols
approved these changes
Dec 5, 2024
Member
andrewnicols
left a comment
andrewnicols
left a comment
There was a problem hiding this comment.
Thanks for this. Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the way links formed differed based on operating system.
This meant that on Windows the fix-renamed links checker would both change links that it should not, and leave them with Windows style slashes.
This is a fix for Issue #1197