Conversation
✅ Deploy Preview for moodledevdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR reorganizes Moodle Workplace release documentation and supporting code/data to live under dedicated workplace/ paths, aiming to make ownership and maintenance clearer for the Workplace team.
Changes:
- Moved/renamed Workplace version data and schema references to
data/workplace/versions.jsonandstatic/schema/workplace/versions.json. - Introduced Workplace-specific React components under
src/components/workplace/and updated the Workplace releases doc to use them. - Updated navigation (sidebar) and ownership (CODEOWNERS) to reflect the new Workplace structure.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| static/schema/workplace/versions.json | Updates schema $id to Workplace-specific path. |
| src/utils/workplace/SupportedReleases.ts | Points Workplace utilities at the new data file location. |
| src/components/workplace/index.tsx | Adds a Workplace component entrypoint barrel export. |
| src/components/workplace/SupportedReleases/styles.module.css | Adds Workplace-specific styling for release tables. |
| src/components/workplace/SupportedReleases/index.tsx | Refactors Workplace SupportedReleases component to new util import path. |
| src/components/workplace/ReleaseTable/index.tsx | Refactors Workplace ReleaseTable component to new util import path. |
| sidebars/general.js | Updates sidebar doc id to workplace/releases/index. |
| scripts/wp_version.mjs | Updates generator script to use new Workplace data/doc paths. |
| general/workplace/releases/index.md | Updates Workplace releases page to use new Workplace component barrel and new asset path. |
| general/workplace/releases/_index/1680px-workplace_releases_timeline.png | Adds/moves timeline image under _index. |
| data/workplace/versions.json | Updates $schema reference to new schema path. |
| CODEOWNERS | Adds Workplace ownership entries for the new directories/files. |
Comments suppressed due to low confidence (3)
src/components/workplace/ReleaseTable/index.tsx:22
- Import path casing looks incorrect: the repo has
src/utils/workplace/SupportedReleases.ts(lowercaseworkplace), but this imports from@site/src/utils/Workplace/SupportedReleases. This will break in case-sensitive environments. Use the correct lowercase path.
general/workplace/releases/index.md:10 - The import path casing doesn't match the actual directory name (
src/components/workplace). On case-sensitive filesystems this will fail to resolve. Update the import to use the correct casing/path (e.g.@site/src/components/workplace).
src/components/workplace/SupportedReleases/index.tsx:28 - Import path casing looks incorrect: the repo has
src/utils/workplace/SupportedReleases.ts(lowercaseworkplace), but this imports from@site/src/utils/Workplace/SupportedReleases. This will break in case-sensitive environments. Use the correct lowercase path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
70f83ec to
fafbba9
Compare
lostrogit
left a comment
There was a problem hiding this comment.
Hi @andrewnicols, thanks for the proposed changes, all looks much more organised now.
We would have preferred not to fork the table/supported releases components; we tried to reuse them, but as you noticed, our approach is slightly different, so we forked them and applied our custom changes.
Merging the schemas sounds reasonable, especially since we only require a few additional fields. We’ve created a follow-up issue (WP-5990) to extend the new release page so that we can do it there. I’ll ping you once we start working on it so you can provide your feedback.
Thanks
fafbba9 to
178b67c
Compare
|
Thanks both! |
Pinging @lostrogit and @paulholden,
I've modified the general layout here to make this more manageable by your team.
Ideally I would have preferred not to have forked the release table and supported releases components but these seem to be fairly different.
I do also wonder if we could have merged the two version schemas