Allow AMOS to perform git commands #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
+ Coverage 30.90% 33.01% +2.10%
==========================================
Files 71 71
Lines 3229 3229
==========================================
+ Hits 998 1066 +68
+ Misses 2231 2163 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewnicols
force-pushed
the
gitinamos
branch
4 times, most recently
from
bb355bd to
a9019cc
Compare
This prevent issues when passing a large number of changes files to the amos script. Previously the git commands were run in the shell script and values passed to the php script, but where there are large numbers of files this breaks because PHP hits ARG limits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevent issues when passing a large number of changes files to the amos script.
Previously the git commands were run in the shell script and values passed to the php script, but where there are large numbers of files this breaks because PHP hits ARG limits.
This issue has come about because I'm hitting these limits in MDL-83424