Split locales generation out from php extensions installation #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to modify the php installed extensions in the images it's a pain to have to wait for all the locales to be generated. So, the changes here just split that responsibility to another, separated layer that will be cached before playing with extensions.
Member
Author
|
Self-merging (it has been already tested in the "dev" branch (8.3 alpha1) and it's working ok... will cherry pick the change to all images then. |
Member
Author
|
Done, the PR has been cherry-picked to all php >= 7.4 images. They are being rebuilt now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to modify the php installed extensions in the images it's a pain to have to wait for all the locales to be generated.
So, the changes here just split that responsibility to another, separated layer that will be cached before playing with extensions.
If accepted, I'll spread the change over all the versions...
Ciao :-)