Skip to content

Conversation

@stronk7
Copy link
Member

@stronk7 stronk7 commented May 21, 2019

Using 2.4.0 release + custom patch (from macports project) seems to
be the only working combination right now. Read the comments in the code
and the links there.

Resolves solr issue in #16, waiting for the upstream as described in #19

Using 2.4.0 release + custom patch (from macports project) seems to
be the only working combination right now. Read the comments in the code
and the links there.

Resolves solr issue in moodlehq#16, waiting for the upstream as described in moodlehq#19
@stronk7
Copy link
Member Author

stronk7 commented May 21, 2019

For the records:

$ bin/moodle-docker-compose exec webserver vendor/bin/phpunit search_solr_engine_testcase
Moodle 3.8dev (Build: 20190520), a866c5c23866fe527282429384ddbcb902c41c14
Php: 7.3.5, pgsql: 9.6.7, OS: Linux 4.9.125-linuxkit x86_64
PHPUnit 7.5.9 by Sebastian Bergmann and contributors.

.............................                                     29 / 29 (100%)

Time: 32.75 seconds, Memory: 71.00 MB

OK (29 tests, 235 assertions)

@stronk7
Copy link
Member Author

stronk7 commented May 22, 2019

(and confirmed that search_solr_engine_testcase continue passing locally with the 2nd commit, fixing the patch version, good idea @andrewnicols )

$ bin/moodle-docker-compose exec webserver vendor/bin/phpunit search_solr_engine_testcase
Moodle 3.8dev (Build: 20190520), a866c5c23866fe527282429384ddbcb902c41c14
Php: 7.3.5, pgsql: 9.6.7, OS: Linux 4.9.125-linuxkit x86_64
PHPUnit 7.5.9 by Sebastian Bergmann and contributors.

.............................                                     29 / 29 (100%)

Time: 41.74 seconds, Memory: 71.00 MB

OK (29 tests, 235 assertions)

@andrewnicols andrewnicols merged commit d6a81a6 into moodlehq:7.3-stretch May 23, 2019
@stronk7 stronk7 deleted the solr73 branch May 23, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants