feat: enhance firefox 144+ master key retrieval and improve padding validation#499
Merged
moonD4rk merged 3 commits intomoonD4rk:mainfrom Mar 3, 2026
Merged
feat: enhance firefox 144+ master key retrieval and improve padding validation#499moonD4rk merged 3 commits intomoonD4rk:mainfrom
moonD4rk merged 3 commits intomoonD4rk:mainfrom
Conversation
moonD4rk
approved these changes
Mar 3, 2026
Owner
|
LGTM, Great Job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
PR #498 missed a scenario where multiple candidate keys would cause an error in Firefox, preventing password decryption. While the cause of multiple candidate keys is currently unknown, this issue occurred on both my test machine and my work PC.
This problem has now been fixed, and the code robustness has been improved.
I tested it with versions 143 (one candidate key), 144 (one candidate key), and 148 (two candidate keys), and the code runs correctly.
Checklist