Skip to content

feat: enhance firefox 144+ master key retrieval and improve padding validation#499

Merged
moonD4rk merged 3 commits intomoonD4rk:mainfrom
Aquilao:main
Mar 3, 2026
Merged

feat: enhance firefox 144+ master key retrieval and improve padding validation#499
moonD4rk merged 3 commits intomoonD4rk:mainfrom
Aquilao:main

Conversation

@Aquilao
Copy link
Collaborator

@Aquilao Aquilao commented Mar 3, 2026

Proposed changes

PR #498 missed a scenario where multiple candidate keys would cause an error in Firefox, preventing password decryption. While the cause of multiple candidate keys is currently unknown, this issue occurred on both my test machine and my work PC.

image

This problem has now been fixed, and the code robustness has been improved.

I tested it with versions 143 (one candidate key), 144 (one candidate key), and 148 (two candidate keys), and the code runs correctly.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit, build tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@moonD4rk
Copy link
Owner

moonD4rk commented Mar 3, 2026

LGTM, Great Job!

@moonD4rk moonD4rk merged commit 3a89cb6 into moonD4rk:main Mar 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants