Fix string indexing warnings and type conversion#3
Merged
peter-jerry-ye merged 1 commit intomainfrom Dec 3, 2025
Merged
Conversation
- Replace @string.View with StringView type alias - Convert method syntax from fn meth(self : Type, ..) to fn Type::meth(..) - Replace deprecated substring() calls with StringView.view() methods - Update interface file to reflect new method signatures All changes are minimal and focused on eliminating warnings while maintaining full backward compatibility. moon check now passes with 0 warnings and 0 errors. All 65 tests pass successfully. Co-authored-by: openhands <openhands@all-hands.dev>
Pull Request Test Coverage Report for Build 8Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed compilation warnings in the string_zipper package by updating string indexing operations to use the correct UInt16 return type instead of the deprecated Int type.
Changes
Why These Changes Were Made
The MoonBit language changed the return type of string indexing from
InttoUInt16. This update ensures:moon checkpasses without warningsImplementation Details
The changes focus on converting string indexing results from the new
UInt16type toIntwhere needed for compatibility with existing code logic. This approach maintains backward compatibility while adhering to the updated language requirements.