Skip to content

Conversation

@bobzhang
Copy link
Contributor

  • filter target to make output more stable
  • add extra payload to make OSError more helpful when possible

@coveralls
Copy link

coveralls commented Oct 28, 2025

Pull Request Test Coverage Report for Build 696

Details

  • 28 of 40 (70.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 78.065%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/internal/event_loop/network.mbt 3 4 75.0%
src/internal/event_loop/fs.mbt 25 36 69.44%
Totals Coverage Status
Change from base Build 693: -0.5%
Covered Lines: 1178
Relevant Lines: 1509

💛 - Coveralls

Copy link

@tonyfettes tonyfettes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Guest0x0
Copy link
Collaborator

The idea lgtm, I'll simplify the implementation a bit (directly in this PR).

@Guest0x0
Copy link
Collaborator

  • merge the extra info directly in the context field, so that we don't have to change the representation of @os_error.OSError (otherwise it would technically be a breaking change. The layout of OSError is also simpler this way)
  • instead of adding the extra payload everywhere, let the relevant primtives (open, getaddrinfo) append the file name/path to context directly via catch. This way there is no need for (internal) API change

@Guest0x0 Guest0x0 merged commit d98b1cf into main Oct 29, 2025
10 checks passed
@Guest0x0 Guest0x0 deleted the hongbo/helpful_oserror branch October 29, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants