Skip to content

handle should be pointer on Windows#292

Merged
Guest0x0 merged 1 commit intomainfrom
windows-handle-should-be-pointer
Feb 2, 2026
Merged

handle should be pointer on Windows#292
Guest0x0 merged 1 commit intomainfrom
windows-handle-should-be-pointer

Conversation

@Guest0x0
Copy link
Copy Markdown
Collaborator

@Guest0x0 Guest0x0 commented Feb 2, 2026

According to https://learn.microsoft.com/en-us/windows/win32/winprog/windows-data-types, the ABI of HANDLE should be void* on Windows. Currently it is UInt64, which can be problematic for 32bit tool chains.

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1276

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 67.779%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/internal/fd_util/fd_util.mbt 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/internal/event_loop/thread_pool.mbt 1 40.0%
src/internal/event_loop/event_loop.mbt 3 57.33%
Totals Coverage Status
Change from base Build 1272: -0.1%
Covered Lines: 1849
Relevant Lines: 2728

💛 - Coveralls

@Guest0x0 Guest0x0 merged commit 1c05bf4 into main Feb 2, 2026
15 checks passed
@Guest0x0 Guest0x0 deleted the windows-handle-should-be-pointer branch February 2, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants