Conversation
Coverage Report for CI Build 254Coverage remained the same at 78.662%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Guest0x0
force-pushed
the
windows-reuse-addr
branch
from
da11708 to
4f94369
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
reuse_addroption for@socket.TcpServeris intended for enabling fast restart of server, ignoringTIME_WAITconnections from the last run of the server. This is currently implemented viaSO_REUSEADDRon all platforms. However, on Windows,TIME_WAITsockets are ignored by default and this behavior is not configurable, so in effectreuse_addris alwaystrueon Windows no matter what we do. Meanwhile,SO_REUSEADDRhas completely different meaning on Windows. It is more likeSO_REUSEPORTon other systems, and has bad security implications.This PR no longer emits
SO_REUSEADDRon Windows, and document the platform-dependent behavior ofreuse_addrmore clearly (it has some side effects on MacOS/BSD that cannot be isolated).