[codex] add fn syntax to trait implementations#395
Merged
Conversation
Coverage Report for CI Build 361Coverage increased (+0.05%) to 79.332%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
Author
|
CI status after monitoring:
I checked the formatter log. The failure is the broader formatter migration already split into #394: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out the safe
fnsyntax portion from the broader formatter/info PR.fnto trait member declarations where neededimpl ... withdeclarations toimpl ... with fnsrc/io/pkg.generated.mbtiwith the matching public trait syntaxThis intentionally does not include the
moon fmtmanifest migration or the broader formatter/test-helper changes from #394.Validation
moon check --deny-warnmoon check --target js --deny-warnmoon infogit diff --checkmoon test --deny-warnwas also run locally, but this environment reported existing-looking fs/process timing and file-lock failures unrelated to this syntax-only change:fs/lock_test.mbtandprocess/spawn_in_group_test.mbt/process/cancel_test.mbt.