Enable stdio on wasm#482
Merged
Merged
Conversation
peter-jerry-ye
force-pushed
the
codex/async-stdio-wasm
branch
from
ef88854 to
6463004
Compare
Coverage Report for CI Build 777Coverage increased (+0.04%) to 77.236%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
peter-jerry-ye
force-pushed
the
codex/async-stdio-wasm
branch
3 times, most recently
from
4d93627 to
1a13f81
Compare
peter-jerry-ye
force-pushed
the
codex/async-stdio-wasm
branch
from
1a13f81 to
c0da033
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a13f819a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
peter-jerry-ye
force-pushed
the
codex/async-stdio-wasm
branch
from
c0da033 to
6c3ba8d
Compare
peter-jerry-ye
force-pushed
the
codex/async-stdio-wasm
branch
from
6c3ba8d to
142c753
Compare
peter-jerry-ye
force-pushed
the
codex/async-stdio-wasm
branch
from
142c753 to
a6ab975
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
moonbitlang/async/stdiowas still native-only, so wasm users could not access standard input, output, or error through the async IO abstractions.What
This enables the internal stdio event-loop setup and public
stdiopackage on wasm, then adds a small handle-availability regression test.Why This Is Correct
The public
stdioAPI stays unchanged. The shared stdio setup still takes logical standard stream ids (0,1,2) like the native implementation. Upstream now always routes stdio through the thread pool, so wasm only needs a target-specificget_stdio_handle(id)import and the existing fd-kind import.Scope
This is limited to wasm stdio package support. Native stdio behavior is unchanged.