Skip to content

Conversation

@bobzhang
Copy link
Contributor

Reverts #1576

This reverts commit 8421d62.
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5128

Details

  • 34 of 47 (72.34%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 85.865%

Changes Missing Coverage Covered Lines Changed/Added Lines %
builtin/bytes.mbt 0 3 0.0%
builtin/arrayview.mbt 23 33 69.7%
Totals Coverage Status
Change from base Build 5127: -0.2%
Covered Lines: 5279
Relevant Lines: 6148

💛 - Coveralls

@bobzhang
Copy link
Contributor Author

Note the compiler hardcoded BytesView in Basic_type_path, so we can not move BytesView from builtin to bytes without changes from upstream see #1581
cc @Yu-zh

@bobzhang bobzhang added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 0dd9b2d Jan 27, 2025
14 checks passed
@bobzhang bobzhang deleted the revert-1576-view branch January 27, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants