refactor: simplify patterns in sorted_map, sorted_set, and queue#3314
Open
refactor: simplify patterns in sorted_map, sorted_set, and queue#3314
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
bobzhang
force-pushed
the
hongbo/simplify-patterns
branch
from
37287d0 to
ff6f67d
Compare
Collaborator
Pull Request Test Coverage Report for Build 3063Details
💛 - Coveralls |
bobzhang
changed the title
sorted_map: use `is Some(_)` instead of match for contains sorted_set: use `iter().all()` instead of mutable accumulator with each callback for subset and disjoint Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bobzhang
force-pushed
the
hongbo/simplify-patterns
branch
from
ff6f67d to
378fd68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
containsto useself.get(key) is Some(_)instead of a full match expressioneachpattern withiter().all()insubsetanddisjointpeekto useself.first.map(first => first.content)instead of explicit matchTest plan
🤖 Generated with Claude Code