Skip to content

refactor: move debug impls into owner packages#3321

Open
peter-jerry-ye wants to merge 2 commits intomainfrom
zihang/move-debug
Open

refactor: move debug impls into owner packages#3321
peter-jerry-ye wants to merge 2 commits intomainfrom
zihang/move-debug

Conversation

@peter-jerry-ye
Copy link
Collaborator

@peter-jerry-ye peter-jerry-ye commented Mar 20, 2026

Motivation

Currently debug imports everything, even those immut containers, which makes it easy to create dependency cycle (see #3309 (comment))

Summary

  • move package-owned Debug impls and related tests out of debug into their owner packages
  • add deprecated explicit Type::to_repr methods for the moved named types so callers migrate to to_repr(x)
  • trim debug package dependencies and update affected imports and debug call sites

Testing

  • moon check
  • moon info
  • moon fmt
  • moon test

Open with Devin

@coveralls
Copy link
Collaborator

coveralls commented Mar 20, 2026

Pull Request Test Coverage Report for Build 3095

Details

  • 327 of 328 (99.7%) changed or added relevant lines in 20 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.734%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bytes/internal/regex_engine/ast/pattern.mbt 0 1 0.0%
Totals Coverage Status
Change from base Build 3090: 0.02%
Covered Lines: 13780
Relevant Lines: 14394

💛 - Coveralls

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eeda2d7f88

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

devin-ai-integration[bot]

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants