perf(hashmap): fix from_array to avoid mid-build rehashing#3330
Merged
perf(hashmap): fix from_array to avoid mid-build rehashing#3330
Conversation
Collaborator
Pull Request Test Coverage Report for Build 3153Details
💛 - Coveralls |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
bobzhang
force-pushed
the
perf/hashmap-from-array-capacity
branch
from
6f22b48 to
4a578ba
Compare
from_array was creating the initial table with capacity=arr.length(), but the map grows at 50% load factor. This meant construction would always trigger a rehash after inserting only half the elements. Fix: use capacity=arr.length()*2 so all input entries fit without triggering the grow threshold during construction. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bobzhang
force-pushed
the
perf/hashmap-from-array-capacity
branch
from
4a578ba to
0dc0f9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from_arraywas creating the initial table withcapacity=arr.length(), but the map grows at 50% load factor. This meant construction always triggered a rehash after inserting only half the elements.capacity=arr.length()*2.Test plan
moon test -p moonbitlang/core/hashmappasses (115/115 tests)🤖 Generated with Claude Code