Skip to content

refactor: move debug impls to owner packages and add BigInt internal debug#3342

Merged
bobzhang merged 1 commit intomainfrom
hongbo/internal_debug
Mar 25, 2026
Merged

refactor: move debug impls to owner packages and add BigInt internal debug#3342
bobzhang merged 1 commit intomainfrom
hongbo/internal_debug

Conversation

@bobzhang
Copy link
Copy Markdown
Contributor

@bobzhang bobzhang commented Mar 25, 2026

Summary

  • Refactored Debug trait implementations out of the centralized debug package into their respective owner packages (hashmap, hashset, list, queue, deque, etc.), reducing coupling and improving maintainability
  • Added @debug.Debug implementation for BigInt with internal debug support
  • Fixed several bugs: list.scan_left double evaluation, priority_queue.copy() stack overflow, immut/array missing bounds checks, sorted_map.range() incorrect comments
  • Performance improvements: hashmap.from_array avoids mid-build rehashing, string.Regex.replace_by delays StringBuilder allocation

Test plan

  • CI passes all existing tests
  • New tests for sorted_map.range(), priority_queue.copy(), immut/array bounds checking

🤖 Generated with Claude Code


Open with Devin

@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 3167

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.742%

Totals Coverage Status
Change from base Build 3162: 0.0%
Covered Lines: 13829
Relevant Lines: 14444

💛 - Coveralls

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@bobzhang bobzhang merged commit fa12382 into main Mar 25, 2026
14 checks passed
@bobzhang bobzhang deleted the hongbo/internal_debug branch March 25, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants