refactor: Preallocate UTF-8 encoding output#3434
Open
peter-jerry-ye wants to merge 1 commit intomainfrom
Open
Conversation
Collaborator
Coverage Report for CI Build 3833Coverage decreased (-0.02%) to 94.892%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@encoding/utf8.encode's buffer-based implementation with a two-pass encoder that sizes the UTF-8 output first and writes directly into oneFixedArray[Byte]Why
The previous implementation encoded through
Buffer::write_string_utf8, which iterated by code point and paid repeated grow checks on the hot path. This change keeps the work at the UTF-16 code-unit level, does one preallocation, and then writes bytes directly.Impact
Validation
moon test encoding/utf8/encode_test.mbt --target allmoon check encoding/utf8 --target allmoon fmtmoon info encoding/utf8moon bench -p tmp/utf8_encode_bench --target native --releasemoon bench -p tmp/utf8_encode_bench --target js --releasemoon bench -p tmp/utf8_encode_bench --target wasm --releasemoon bench -p tmp/utf8_encode_bench --target wasm-gc --releaseNotes
The temporary
tmp/utf8_encode_benchpackage used for measurement was removed before commit.