[codex] Fix parse_double huge exponent handling#3464
Closed
bobzhang wants to merge 1 commit into
Closed
Conversation
Collaborator
Coverage Report for CI Build 3923Coverage decreased (-0.01%) to 94.879%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
parse_doubleslow-path handling for decimal strings with extremely large exponent fields.The decimal fallback previously accumulated the exponent in an
Intwithout a cap. Inputs such as1e999999999999999999999999999999999999could overflow that accumulator and produce a small finite value instead of reporting range overflow. The fix clamps exponent accumulation once the value is already beyond the slow path's overflow or underflow thresholds.Validation
moon fmt internal/strconvmoon info internal/strconvmoon test internal/strconvmoon checkmoon test