refactor(builtin): FixedArray/ReadOnlyArray::starts_with/ends_with take ArrayView#3471
Open
refactor(builtin): FixedArray/ReadOnlyArray::starts_with/ends_with take ArrayView#3471
Conversation
…ke ArrayView Mirrors the recently-merged Array migration. Both FixedArray and ReadOnlyArray slice to ArrayView[T], so the prefix/suffix parameter becomes ArrayView[T] for symmetry with Array, String, and Bytes. Existing callers passing array literals are unaffected — the literal is inferred as an ArrayView. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Collaborator
Coverage Report for CI Build 3947Coverage decreased (-0.001%) to 94.887%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the recently-merged
Array::starts_with/ends_withmigration (#3470). BothFixedArrayandReadOnlyArrayslice toArrayView[T], so making the prefix/suffix parameter anArrayView[T]keeps the API symmetric withArray,String, andBytes.Existing callers that pass an array literal (
arr.starts_with([1, 2])) continue to work — the literal is inferred as anArrayView.Test plan
moon fmt,moon infomoon test -p moonbitlang/core/builtin— 2812/2812 pass