feat(argparse): derive Debug for public types#3477
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Collaborator
Coverage Report for CI Build 4017Coverage remained the same at 94.877%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
bobzhang
force-pushed
the
add-debug-argparse
branch
from
9ea2261 to
d95d0e8
Compare
Adds @debug.Debug derive for ArgGroup, Command, FlagAction, FlagArg, OptionAction, OptionArg, PositionArg, ValueRange. Internal Arg, ArgInfo and ArgBuildError also gain Debug so the public structs cascade through their private fields.
The previous fix duplicated using @debug across 5 files, which the stable moon toolchain rejects with [4051] 'type Repr is declared twice'. Remove the duplicates; matches.mbt already has the using declaration.
bobzhang
force-pushed
the
add-debug-argparse
branch
from
d95d0e8 to
3eaab15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@debug.Debugderive for the public typesArgGroup,Command,FlagAction,FlagArg,OptionAction,OptionArg,PositionArg,ValueRange.Arg,ArgInfo,ArgBuildErroralso gain Debug so the public struct derives cascade.Test plan
moon test -p moonbitlang/core/argparsepasses on all 4 targets (129 tests)🤖 Generated with Claude Code