Skip to content

feat(json): derive Debug for ParseError, Position, Replacer#3478

Merged
bobzhang merged 3 commits intomainfrom
add-debug-json
Apr 27, 2026
Merged

feat(json): derive Debug for ParseError, Position, Replacer#3478
bobzhang merged 3 commits intomainfrom
add-debug-json

Conversation

@bobzhang
Copy link
Copy Markdown
Contributor

@bobzhang bobzhang commented Apr 27, 2026

Summary

  • Adds @debug.Debug derive to ParseError, Position, Replacer.
  • Replacer's closure field renders as <function: ...> via the default Debug derive (no ignore= needed).
  • Part of an audit filling in Debug impls for every public type in core.

Test plan

  • moon test -p moonbitlang/core/json passes on all 4 targets (170 tests)

🤖 Generated with Claude Code


Open in Devin Review

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 27, 2026

Coverage Report for CI Build 4018

Coverage remained the same at 94.877%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15576
Covered Lines: 14778
Line Coverage: 94.88%
Coverage Strength: 220300.07 hits per line

💛 - Coveralls

@bobzhang bobzhang enabled auto-merge (squash) April 27, 2026 06:42
ParseError and Position add @debug.Debug to their existing derive lists.
Replacer derives Debug too; the closure field renders as
<function: ...> via the default Debug derive behaviour.
@bobzhang bobzhang merged commit 650227b into main Apr 27, 2026
12 of 19 checks passed
@bobzhang bobzhang deleted the add-debug-json branch April 27, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants