fix(coverage): break import cycle with debug#3491
Merged
Conversation
`coverage/debug.mbt` (added in #3482) introduced a `Debug` impl for `CoverageCounter`, which made `coverage` import `debug`. With `--enable-coverage`, the toolchain implicitly injects coverage into every package — including `debug` itself — producing the cycle: abort -> prelude -> coverage -> debug -> coverage This causes `moon test --enable-coverage` (and the misc-check CI job) to fail with "Import loop detected". Removes `coverage/debug.mbt` and the `debug` import from `coverage/moon.pkg`. The only observable API change is that `CoverageCounter` no longer has a `Debug` impl — it's an internal counter type that callers shouldn't be debug-printing in normal code. After this change `moon test --enable-coverage` runs clean (6369/6369). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Coverage Report for CI Build 4042Warning No base build found for commit Coverage: 94.817%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coverage/debug.mbt(added in #3482) introduced aDebugimpl forCoverageCounter, which madecoverageimportdebug. With--enable-coverage, the toolchain implicitly injects coverage into every package — includingdebugitself — producing the cycle:This causes
moon test --enable-coverage(and themisc-checkCI job) to fail withImport loop detected.Fix
coverage/debug.mbt."moonbitlang/core/debug"fromcoverage/moon.pkg.The only observable API change is that
CoverageCounterno longer has aDebugimpl — it's an internal counter type that callers shouldn't be debug-printing in normal code.Repro
Test plan
moon test --enable-coverage— 6369/6369 pass after the fix.moon test— 6364/6364 pass.mbti diff (
coverage)🤖 Generated with Claude Code