feat(encoding): add hex package#3625
Open
bobzhang wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new moonbitlang/core/encoding/hex package providing deterministic, in-memory lowercase hexadecimal encoding/decoding utilities, mirroring Go’s encoding/hex API style (including encoded_len/decoded_len) and documenting malformed-input behavior.
Changes:
- Introduces
encode,decode,encoded_len, anddecoded_lenAPIs plus aMalformederror type. - Adds comprehensive unit tests for encoding/decoding (including all-byte roundtrip and malformed inputs).
- Adds package README with runnable examples.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| encoding/hex/README.mbt.md | Documents API, malformed behavior, and provides runnable examples. |
| encoding/hex/pkg.generated.mbti | Generated public interface for the new package. |
| encoding/hex/moon.pkg | Declares package imports needed by the implementation/tests. |
| encoding/hex/encode.mbt | Implements lowercase hex encoding and encoded_len. |
| encoding/hex/encode_test.mbt | Tests encoding correctness and encoded_len. |
| encoding/hex/decode.mbt | Implements hex decoding, decoded_len, and Malformed error. |
| encoding/hex/decode_test.mbt | Tests decoding correctness, malformed handling, and Debug output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Coverage Report for CI Build 4482Coverage increased (+0.008%) to 94.097%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
moonbitlang/core/encoding/hexfor in-memory lowercase hexadecimal encoding and decodingencoded_len/decoded_lenhelpersScope
Validation
moon checkmoon test encoding/hexmoon test