[codex] Refactor source location JSON builder#3630
Merged
Conversation
Collaborator
Coverage Report for CI Build 4496Coverage decreased (-0.002%) to 94.076%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors SourceLocRepr::to_json_string in builtin/autoloc.mbt to use the StringBuilder interpolation append form while preserving the exact compact JSON output format (including escaped filenames and numeric fields).
Changes:
- Replaced a sequence of
write_stringcalls with a singlesb <+ $|...interpolated append. - Kept filename escaping behavior by continuing to delegate to
StringView::escape_to. - Maintained field order and compact formatting to avoid snapshot/test diffs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SourceLocRepr::to_json_stringto use theStringBuilderinterpolation append form.Review notes
During local review, the initial refactor emitted extra JSON whitespace and failed the source location snapshots. I adjusted the interpolation literal to keep the previous output stable.
Validation
moon fmtmoon info(no.mbtichanges)moon test builtin/source_loc_wbtest.mbtmoon checkmoon test(6502 passed)