[codex] Add Debug support for common types#250
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81d2496776
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ///| | ||
| pub impl Debug for Zone with fn to_repr(self : Zone) -> Repr { | ||
| Repr::ctor("Zone", [(None, Repr::string(self.to_string()))]) |
There was a problem hiding this comment.
Include offsets in Zone debug output
Because this Debug impl only uses the zone id, distinct zones can render identically: for example utc_zone and fixed_zone("UTC", 3600) both debug as Zone("UTC") even though fixed_zone accepts an arbitrary id and offset. That makes debug_inspect assertions unable to catch wrong fixed offsets or loaded TZ data when the id matches; include the offset data (and transitions for non-fixed zones) in the repr so the debug value reflects the actual zone being tested.
Useful? React with 👍 / 👎.
362e875 to
47b9769
Compare
47b9769 to
5655bd6
Compare
Summary
Validation