feat: Do not emit info logs by default#2239
Merged
Merged
Conversation
Use `-v` to get info level logs, and `-vv` to get debug level logs.
This reverts behavior to approximately the same as the old default when running as a systemd service.
Instead of making up our own DelayedHandler.
It is entirely normal to have a system-wide config file that cannot be read by regular users, so we shouldn't log this on warning level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we logged on info level by default, except for the
configanddepscommands, which only logged on warning level to make them work better as short-running CLI commands instead of long-running processes.Now, logging works the same for all commands: We log on warning level by default. Pass
-vor--verboseto log on info level. This makes all commands, from both core and extensions, work consistently and unsurprisingly.The systemd service file we ship has been adjusted to reenable info level logging when running as a systemd service, as that behavior still makes the most sense for long-running processes.