Skip to content

Add missing container field to media configs#1143

Merged
kixelated merged 1 commit intomoq-dev:mainfrom
Qizot:moq-ffi-container-field
Mar 20, 2026
Merged

Add missing container field to media configs#1143
kixelated merged 1 commit intomoq-dev:mainfrom
Qizot:moq-ffi-container-field

Conversation

@Qizot
Copy link
Contributor

@Qizot Qizot commented Mar 20, 2026

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9c1dff0d-ce25-483c-b4cb-35278708b520

📥 Commits

Reviewing files that changed from the base of the PR and between d543d18 and a394bd9.

📒 Files selected for processing (1)
  • rs/moq-ffi/src/media.rs

Walkthrough

This change introduces container format metadata to the media representation layer. A new Container enum was added with Legacy and Cmaf variants, where the latter includes a timescale and track ID. The MoqVideo and MoqAudio structs were extended with a container field of this new type. A conversion implementation was added to transform source container types into the new enum format. The convert_catalog function was updated to populate the container field for both video and audio rendition entries during catalog conversion.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No description was provided by the author, making it impossible to evaluate relevance to the changeset. Add a pull request description explaining the purpose and context of adding the container field to media configs.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a container field to media configuration structures (MoqVideo and MoqAudio).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

@kixelated kixelated merged commit 17554ff into moq-dev:main Mar 20, 2026
1 of 2 checks passed
@moq-bot moq-bot bot mentioned this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants