Skip to content

fix: just dev should run the full demo#1237

Merged
kixelated merged 2 commits intomainfrom
fix/dev-command
Apr 7, 2026
Merged

fix: just dev should run the full demo#1237
kixelated merged 2 commits intomainfrom
fix/dev-command

Conversation

@kixelated
Copy link
Copy Markdown
Collaborator

Summary

  • just dev was only running just demo web (the Vite dev server alone)
  • Changed it to run just demo, which concurrently starts the relay, publisher (bbb), and web client

Test plan

  • Run just dev and verify all three services start concurrently

🤖 Generated with Claude Code

kixelated and others added 2 commits April 7, 2026 13:59
`just dev` was only running `just demo web` (the Vite dev server), but it
should run `just demo` which concurrently starts the relay, publisher, and
web client.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The boytacean build.rs tries to write generated code to its source
directory, which fails in Nix's read-only sandbox. The gen-mock
feature skips this code generation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ad127e14-b078-4b8f-a503-80a3fad48c47

📥 Commits

Reviewing files that changed from the base of the PR and between 70fb581 and 6747aaa.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • justfile
  • rs/moq-boy/Cargo.toml

Walkthrough

The changes include modifications to the build configuration and dependency management. The justfile's dev alias has been simplified to invoke just demo instead of just demo web, with its documentation comment updated accordingly. Additionally, the moq-boy crate version has been incremented from 0.2.1 to 0.2.2, and the boytacean dependency specification has been updated to explicitly enable the gen-mock feature.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating just dev to run the full demo instead of only the web server component.
Description check ✅ Passed The description is directly related to the changeset, explaining why the change was made and providing a test plan for verification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dev-command
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/dev-command

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated merged commit ef35f73 into main Apr 7, 2026
1 of 2 checks passed
@kixelated kixelated deleted the fix/dev-command branch April 7, 2026 21:11
@moq-bot moq-bot bot mentioned this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant