Skip to content

Update fly.toml to use the hosted docker image#1331

Merged
kixelated merged 1 commit intomoq-dev:mainfrom
mmcc:patch-1
Apr 19, 2026
Merged

Update fly.toml to use the hosted docker image#1331
kixelated merged 1 commit intomoq-dev:mainfrom
mmcc:patch-1

Conversation

@mmcc
Copy link
Copy Markdown
Contributor

@mmcc mmcc commented Apr 19, 2026

Tiny little baby change, but when I went to deploy the relay to Fly it failed because it couldn't pull the image from dockerhub. This just updates the fly.toml config to use the full name of the hosted image.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 19, 2026

Walkthrough

The Fly.io configuration for the moq-relay application was updated by changing the build image reference in the [build] section of rs/moq-relay/fly.toml. The Docker image name was changed from moq-relay:latest to moqdev/moq-relay:latest. This is a single-line configuration adjustment with no changes to service definitions, ports, environment variables, or public APIs.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating fly.toml to reference the full Docker image name for the hosted image.
Description check ✅ Passed The description clearly explains the reason for the change and directly relates to the fly.toml modification for Docker image configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@rs/moq-relay/fly.toml`:
- Line 4: The inline comment "Built with `nix build .#moq-relay-docker`" in
fly.toml is outdated; either remove that line or replace it with a short note
stating that the service now pulls a pre-built image from Docker Hub (e.g.,
"Image pulled from Docker Hub, no local Nix build required"), so update or
delete the exact comment string to avoid confusion.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 16095f85-bddd-42d2-b7b5-0cd21808e2c5

📥 Commits

Reviewing files that changed from the base of the PR and between e3f0f92 and 1a6374e.

📒 Files selected for processing (1)
  • rs/moq-relay/fly.toml

Comment thread rs/moq-relay/fly.toml
@@ -3,7 +3,7 @@ primary_region = 'sjc'

# Built with `nix build .#moq-relay-docker`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Update or remove the outdated comment.

The comment references building with Nix (nix build .#moq-relay-docker), but the configuration now pulls a pre-built image from Docker Hub. This creates confusion about the intended build process.

Consider updating the comment to reflect the new approach or removing it if it's no longer applicable.

📝 Proposed fix
-# Built with `nix build .#moq-relay-docker`
+# Pulls pre-built image from Docker Hub
 [build]
 image = "moqdev/moq-relay:latest"

Or simply remove the comment if it's no longer needed.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Built with `nix build .#moq-relay-docker`
# Pulls pre-built image from Docker Hub
[build]
image = "moqdev/moq-relay:latest"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@rs/moq-relay/fly.toml` at line 4, The inline comment "Built with `nix build
.#moq-relay-docker`" in fly.toml is outdated; either remove that line or replace
it with a short note stating that the service now pulls a pre-built image from
Docker Hub (e.g., "Image pulled from Docker Hub, no local Nix build required"),
so update or delete the exact comment string to avoid confusion.

@kixelated kixelated merged commit 737389d into moq-dev:main Apr 19, 2026
1 check passed
@kixelated
Copy link
Copy Markdown
Collaborator

ez

I don't remember finishing fly.io support so GOOD LUCK.

This was referenced Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants