Skip to content

Conversation

@Frando
Copy link
Contributor

@Frando Frando commented Feb 12, 2024

This PR has two changes, which allow to reuse the code in moq-pub from other libraries or apps:

  • adds a lib.rs to moq-pub to expose the media module
  • lets the Media struct accept an input: impl AsyncRead argument instead of being hardcoded to stdin

@kixelated
Copy link
Collaborator

although there be a LINT FAILURE.

@Frando
Copy link
Contributor Author

Frando commented Feb 26, 2024

The failure seems unrelated to me?


error: unused import: `string::*`
Error:   --> moq-transport/src/coding/mod.rs:10:9
   |
10 | pub use string::*;
   |         ^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`

@kixelated kixelated merged commit ad5cc5d into moq-dev:main Mar 7, 2024
@kixelated
Copy link
Collaborator

Sorry for the delay!

ajay-s-2502 pushed a commit to ajay-s-2502/moq-rs that referenced this pull request Nov 22, 2024
Co-authored-by: kixelated <kixelated@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants