Skip to content

Unignore moq-mux test fixtures#1382

Merged
kixelated merged 1 commit into
mainfrom
fix-gitignore-mp4-fixtures
May 6, 2026
Merged

Unignore moq-mux test fixtures#1382
kixelated merged 1 commit into
mainfrom
fix-gitignore-mp4-fixtures

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

  • The *.mp4 rule in .gitignore matched the committed test fixtures under rs/moq-mux/src/import/test/, leaving them both tracked and ignored.
  • release-plz refuses to compute next versions in that state, which broke the Release job on main (run 25411375308).
  • Adds !rs/moq-mux/src/import/test/*.mp4 to re-include those fixtures.

Test plan

  • git ls-files -ci --exclude-standard returns empty
  • git check-ignore no longer matches the three fixtures
  • Next Release run on main succeeds

🤖 Generated with Claude Code

The *.mp4 ignore rule was matching the committed test fixtures in
rs/moq-mux/src/import/test/, causing release-plz to fail with
"the working directory of this project has uncommitted changes" because
it refuses to operate when tracked files are also gitignored.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8a3b9884-2205-428b-b3d3-bf5bf213ed4d

📥 Commits

Reviewing files that changed from the base of the PR and between 34dc7c9 and c263f85.

📒 Files selected for processing (1)
  • .gitignore

Walkthrough

A negation rule is added to the .gitignore file to re-include specific MP4 test fixture files. The pattern !rs/moq-mux/src/import/test/*.mp4 creates an exception to a broader MP4 ignore rule, ensuring that MP4 files within the specified test fixtures directory are tracked in version control. An accompanying comment clarifies that these test fixtures are committed to the repository.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: re-including MP4 test fixtures in git tracking by adding a negation rule to .gitignore.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem (files both tracked and ignored), the impact (release-plz failure), and the solution (adding negation pattern).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-gitignore-mp4-fixtures
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix-gitignore-mp4-fixtures

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated enabled auto-merge (squash) May 6, 2026 19:47
@kixelated kixelated disabled auto-merge May 6, 2026 20:03
@kixelated kixelated merged commit 9e2461e into main May 6, 2026
1 check passed
@kixelated kixelated deleted the fix-gitignore-mp4-fixtures branch May 6, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant