Skip to content

moq-ffi: fix uniffi-bindgen invocation, bump to 0.2.9#1392

Merged
kixelated merged 1 commit into
mainfrom
fix-moq-ffi-uniffi-bindgen
May 9, 2026
Merged

moq-ffi: fix uniffi-bindgen invocation, bump to 0.2.9#1392
kixelated merged 1 commit into
mainfrom
fix-moq-ffi-uniffi-bindgen

Conversation

@kixelated
Copy link
Copy Markdown
Collaborator

Summary

The moq-ffi-v0.2.8 release pipeline (run) failed across Generate bindings and the desktop Build jobs (x86_64-apple-darwin, aarch64-apple-darwin, universal-apple-darwin, x86_64-pc-windows-msvc, x86_64-unknown-linux-gnu) with:

error: no bin target named `uniffi-bindgen` in default-run packages
help: available bin in `moq-ffi` package:
    uniffi-bindgen

moq-ffi is intentionally excluded from the workspace's default-members (it requires Python/maturin), so cargo run --bin uniffi-bindgen from rs/moq-ffi/build.sh can't pick the bin without an explicit package. Cross-compiled targets (iOS, Android, aarch64-linux-gnu) skipped the bindings step via can_run_on_host and weren't affected.

Changes

  • rs/moq-ffi/build.sh: pass --package moq-ffi to the cargo run invocation that drives uniffi-bindgen.
  • rs/moq-ffi/Cargo.toml: bump 0.2.80.2.9 so release-plz can re-tag with the fix in place.

Test plan

  • Verified locally: cargo run --release --package moq-ffi --bin uniffi-bindgen --manifest-path Cargo.toml -- --help builds and prints help.
  • After merge, release-plz issues a new moq-ffi-v0.2.9 tag and the release workflow completes.

🤖 Generated with Claude Code

The 0.2.8 release pipeline failed because `cargo run --bin uniffi-bindgen`
in build.sh could not locate the binary: moq-ffi is excluded from the
workspace's default-members, so cargo refuses to pick the bin without an
explicit package. Pass `--package moq-ffi` to disambiguate.

Bumping the patch so release-plz can ship a working tag.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aa2e46d0-baf3-43b5-a8ea-41e0d901127f

📥 Commits

Reviewing files that changed from the base of the PR and between 375cbef and 1d8f050.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • rs/moq-ffi/Cargo.toml
  • rs/moq-ffi/build.sh

Walkthrough

This pull request performs a minor release bump for the moq-ffi crate, incrementing the version from 0.2.8 to 0.2.9 in Cargo.toml. Concurrently, the build script's generate_bindings function was modified to update the cargo run invocation that passes arguments to the uniffi-bindgen binary for language binding generation. No other package dependencies, features, or build logic were altered.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main changes: fixing the uniffi-bindgen invocation and bumping the version to 0.2.9, which directly matches the changeset.
Description check ✅ Passed The description provides detailed context about the root cause of the build failure, explains the specific fix applied, and documents the test plan, all directly relevant to the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-moq-ffi-uniffi-bindgen
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix-moq-ffi-uniffi-bindgen

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated merged commit d9878e7 into main May 9, 2026
1 check passed
@kixelated kixelated deleted the fix-moq-ffi-uniffi-bindgen branch May 9, 2026 21:41
@moq-bot moq-bot Bot mentioned this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant