moq-ffi: fix uniffi-bindgen invocation, bump to 0.2.9#1392
Conversation
The 0.2.8 release pipeline failed because `cargo run --bin uniffi-bindgen` in build.sh could not locate the binary: moq-ffi is excluded from the workspace's default-members, so cargo refuses to pick the bin without an explicit package. Pass `--package moq-ffi` to disambiguate. Bumping the patch so release-plz can ship a working tag. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
WalkthroughThis pull request performs a minor release bump for the moq-ffi crate, incrementing the version from 0.2.8 to 0.2.9 in Cargo.toml. Concurrently, the build script's 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The
moq-ffi-v0.2.8release pipeline (run) failed acrossGenerate bindingsand the desktopBuildjobs (x86_64-apple-darwin, aarch64-apple-darwin, universal-apple-darwin, x86_64-pc-windows-msvc, x86_64-unknown-linux-gnu) with:moq-ffiis intentionally excluded from the workspace'sdefault-members(it requires Python/maturin), socargo run --bin uniffi-bindgenfromrs/moq-ffi/build.shcan't pick the bin without an explicit package. Cross-compiled targets (iOS, Android, aarch64-linux-gnu) skipped the bindings step viacan_run_on_hostand weren't affected.Changes
rs/moq-ffi/build.sh: pass--package moq-ffito thecargo runinvocation that drivesuniffi-bindgen.rs/moq-ffi/Cargo.toml: bump0.2.8→0.2.9so release-plz can re-tag with the fix in place.Test plan
cargo run --release --package moq-ffi --bin uniffi-bindgen --manifest-path Cargo.toml -- --helpbuilds and prints help.moq-ffi-v0.2.9tag and the release workflow completes.🤖 Generated with Claude Code