kio: rename conducer crate to kio#1547
Conversation
The producer/consumer shared-state primitive was named `conducer` (producer + consumer). Rename it to `kio`, a shorter name that fits the moq/tokio ecosystem aesthetic. Starts fresh at 0.3.0 since an unrelated `kio` 0.2.0 was published years ago; the new version leapfrogs it. The API is unchanged, only the crate name and all `conducer::` paths in moq-net and moq-mux. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (31)
💤 Files with no reviewable changes (1)
WalkthroughThis pull request migrates the moq ecosystem from the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reconcile main into dev. Key conflict resolutions: - conducer crate renamed to kio (main #1547): applied across all of dev's newer code; dropped the stale conducer path-dep, kept dev's new flate2 dep. - moq-mux: kept dev's thiserror Result (#1495); dropped main's CatalogSource as dead code since dev's catalog::Consumer already unifies Hang/MSF. - moq-net: kept dev's OriginConsumer/AnnounceConsumer split (#1434) and the TrackConsumer end_at cap; kept dev's non-optional auto-created origins on the lite session/publisher (#e770). - stats: combined main's StatsConfig + liveness retention (#1537, #1548) with dev's AnnounceConsumer usage. - libmoq + moq-native: kept main's auto-reconnect (#1544), terminal-callback contract (#1546), and consume_announced (#1552), adapted to dev's AnnounceConsumer and OriginProducer connect API. Restored the InitFailed error variant and made moq-rtc handle the now-fallible Log::init. cargo check/clippy/test all pass on the merged workspace.
Summary
Renames the
conducercrate (producer + consumer) tokio, a shorter name that fits the moq/tokio ecosystem aesthetic. The crate is the generic async primitive behind moq-net and moq-mux: aProducer/Consumerpair sharing mutex-protected state with waker-based notification.rs/conducer/→rs/kio/(git-tracked as renames, history preserved)name = "kio", version reset to0.3.0conducer::paths, doc links, and prose comments inmoq-netandmoq-muxupdated tokio::just fix)Cargo.lockregeneratedWhy 0.3.0
An unrelated
kio0.2.0was published to crates.io years ago, so the new crate starts at0.3.0to leapfrog it. The API is unchanged. only the crate name differs.Notes for reviewers
rs/moq-net/CHANGELOG.md("Replace mpsc with conducer ...") is left as-is, since it's an accurate record of a past release.rs/kio/CHANGELOG.mdwas reset to a clean0.3.0entry; the oldconducer-v*entries were dropped because they reference old git tags and would be misleading under the new name.main: this is a mechanical rename with no wire/API behavior change. Redirect todevif you'd rather batch the crate-name churn there.Test plan
cargo check -p kio -p moq-net -p moq-muxcargo clippy -p kio -p moq-net -p moq-muxcargo fmt --check(Written by Claude)