build(deps-dev): bump the uv group and fix Container re-export for pyright#1602
Merged
Conversation
Bumps the uv group with 4 updates: [ruff](https://github.com/astral-sh/ruff), [maturin](https://github.com/pyo3/maturin), [pyright](https://github.com/RobertCraigie/pyright-python) and [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio). Updates `ruff` from 0.15.6 to 0.15.14 - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.15.6...0.15.14) Updates `maturin` from 1.12.6 to 1.13.3 - [Release notes](https://github.com/pyo3/maturin/releases) - [Changelog](https://github.com/PyO3/maturin/blob/main/Changelog.md) - [Commits](PyO3/maturin@v1.12.6...v1.13.3) Updates `pyright` from 1.1.408 to 1.1.409 - [Release notes](https://github.com/RobertCraigie/pyright-python/releases) - [Commits](RobertCraigie/pyright-python@v1.1.408...v1.1.409) Updates `pytest-asyncio` from 1.3.0 to 1.4.0 - [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases) - [Commits](pytest-dev/pytest-asyncio@v1.3.0...v1.4.0) --- updated-dependencies: - dependency-name: ruff dependency-version: 0.15.14 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: uv - dependency-name: maturin dependency-version: 1.13.3 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: uv - dependency-name: pyright dependency-version: 1.1.409 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: uv - dependency-name: pytest-asyncio dependency-version: 1.4.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: uv ... Signed-off-by: dependabot[bot] <support@github.com>
pyright 1.1.409 (pulled in by the uv group bump) reports reportPrivateImportUsage when re-importing Container from .subscribe, since it is only an imported name there, not part of that module's public surface. Import it straight from moq_ffi, where it originates, matching how Session is imported.
Contributor
WalkthroughThe change reorganizes the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1597 (the Dependabot PR) by carrying the same
uvgroup bump (ruff, maturin, pyright, pytest-asyncio) plus the fix needed to get CI green.Why
The bump pulls pyright up to 1.1.409, which is stricter about re-exports. CI failed with:
Containeris imported intomoq/subscribe.pyfrommoq_ffibut is not part of that module's public surface (it isn't defined there and there's no__all__listing it). The newer pyright flags re-importing it from.subscribeas a private-import usage.Fix
Import
Containerdirectly frommoq_ffiinmoq/__init__.py, where it originates, matching howSessionis already imported. The other names imported from.subscribe,.publish,.origin, etc. are all classes actually defined in those modules, so they remain unaffected.Test plan
just checkpasses (specificallyuv run --no-sync pyrightreports no errors)(Written by Claude)
Generated by Claude Code