Skip to content

build(deps-dev): bump the uv group and fix Container re-export for pyright#1602

Merged
kixelated merged 2 commits into
mainfrom
claude/github-pr-1597-kQiKR
Jun 3, 2026
Merged

build(deps-dev): bump the uv group and fix Container re-export for pyright#1602
kixelated merged 2 commits into
mainfrom
claude/github-pr-1597-kQiKR

Conversation

@kixelated
Copy link
Copy Markdown
Collaborator

Supersedes #1597 (the Dependabot PR) by carrying the same uv group bump (ruff, maturin, pyright, pytest-asyncio) plus the fix needed to get CI green.

Why

The bump pulls pyright up to 1.1.409, which is stricter about re-exports. CI failed with:

py/moq-rs/moq/__init__.py:16:5 - error: "Container" is not exported from module ".subscribe" (reportPrivateImportUsage)

Container is imported into moq/subscribe.py from moq_ffi but is not part of that module's public surface (it isn't defined there and there's no __all__ listing it). The newer pyright flags re-importing it from .subscribe as a private-import usage.

Fix

Import Container directly from moq_ffi in moq/__init__.py, where it originates, matching how Session is already imported. The other names imported from .subscribe, .publish, .origin, etc. are all classes actually defined in those modules, so they remain unaffected.

Test plan

  • just check passes (specifically uv run --no-sync pyright reports no errors)

(Written by Claude)


Generated by Claude Code

dependabot Bot and others added 2 commits June 3, 2026 00:23
Bumps the uv group with 4 updates: [ruff](https://github.com/astral-sh/ruff), [maturin](https://github.com/pyo3/maturin), [pyright](https://github.com/RobertCraigie/pyright-python) and [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio).


Updates `ruff` from 0.15.6 to 0.15.14
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.15.6...0.15.14)

Updates `maturin` from 1.12.6 to 1.13.3
- [Release notes](https://github.com/pyo3/maturin/releases)
- [Changelog](https://github.com/PyO3/maturin/blob/main/Changelog.md)
- [Commits](PyO3/maturin@v1.12.6...v1.13.3)

Updates `pyright` from 1.1.408 to 1.1.409
- [Release notes](https://github.com/RobertCraigie/pyright-python/releases)
- [Commits](RobertCraigie/pyright-python@v1.1.408...v1.1.409)

Updates `pytest-asyncio` from 1.3.0 to 1.4.0
- [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases)
- [Commits](pytest-dev/pytest-asyncio@v1.3.0...v1.4.0)

---
updated-dependencies:
- dependency-name: ruff
  dependency-version: 0.15.14
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: uv
- dependency-name: maturin
  dependency-version: 1.13.3
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: uv
- dependency-name: pyright
  dependency-version: 1.1.409
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: uv
- dependency-name: pytest-asyncio
  dependency-version: 1.4.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: uv
...

Signed-off-by: dependabot[bot] <support@github.com>
pyright 1.1.409 (pulled in by the uv group bump) reports
reportPrivateImportUsage when re-importing Container from .subscribe,
since it is only an imported name there, not part of that module's
public surface. Import it straight from moq_ffi, where it originates,
matching how Session is imported.
@kixelated kixelated enabled auto-merge (squash) June 3, 2026 01:00
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 3, 2026

Review Change Stack

Walkthrough

The change reorganizes the Container import in the module's public API. Previously, Container was sourced indirectly through the .subscribe module imports. The PR adds a direct import of Container from moq_ffi at the module level and removes it from the .subscribe import list. The public export in __all__ remains unchanged, but now explicitly sources Container from moq_ffi rather than transitively.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the dependency bump, the pyright issue, the fix applied, and the test plan.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main changes: bumping uv group dependencies and fixing the Container re-export issue for pyright compatibility.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/github-pr-1597-kQiKR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated changed the title build(deps-dev): bump the uv group with 4 updates build(deps-dev): bump the uv group and fix Container re-export for pyright Jun 3, 2026
@kixelated kixelated merged commit 796181c into main Jun 3, 2026
3 checks passed
@kixelated kixelated deleted the claude/github-pr-1597-kQiKR branch June 3, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants