refactor(moq-native): migrate from anyhow to thiserror

[kixelated]

Summary

Migrates rs/moq-native from anyhow to thiserror, following the library-crate convention in CLAUDE.md (libraries use thiserror with #[from]; binaries keep anyhow).

Errors are split per concern so each type fully describes its own failures:

• moq_native::tls::Error — certificate/key loading, shared by the client TLS config and the quinn/noq servers.
• moq_native::quinn::Error, noq::Error, quiche::Error, iroh::Error, websocket::Error — one self-contained error type per backend, each returning its own Result.
• moq_native::Error — the top-level type, aggregating all of the above via #[from] and holding the cross-cutting variants (log init, reconnect, backend selection, status code).

Each variant uses #[from] for upstream errors so ? keeps working, with descriptive #[source] variants preserving the previous .context() messages. anyhow moves to [dev-dependencies] (still used by examples and tests).

Because each backend now owns its proto-level error types, the quinn/noq ConnectionError #[from] collision (which needed a cfg workaround when both features were enabled) is gone.

Downstream:

• libmoq gains a #[from] moq_native::Error (Arc-wrapped to keep Error: Clone), so the .init() calls use ? instead of stringifying through anyhow.
• Examples and CLIs use Ok(reconnect.closed().await?) at the reconnect boundary.

Compatibility

Technically breaking: public functions return moq_native's error types instead of anyhow::Error. ? propagation and the anyhow::Context trait (.context() on a Result) still compile for callers; only direct/typed returns into an anyhow::Error slot, or anyhow::Error-inherent methods (.downcast(), .chain(), …), need changes. cargo-semver-checks will detect the return-type change and bump the minor version (0.16.3 → 0.17.0).

Cross-package sync

No paired packages apply: this is an internal error-handling refactor of one crate with no wire, public-API-shape, or catalog change. The crate still exposes std::error::Error types that anyhow-based consumers absorb via ?.

Test plan

• just rs check --workspace (default features): clippy -D warnings, fmt, doc (-D warnings), cargo shear (no unused deps), cargo sort — clean
• cargo clippy --workspace --all-features --all-targets -- -D warnings (quinn + noq + quiche + iroh + jemalloc + websocket together) — clean
• cargo check --workspace --no-default-features — builds
• cargo test -p moq-native — 53 passed, 0 failed
• Downstream libmoq / moq-relay / moq-cli / moq-boy / examples build

🤖 Generated with Claude Code

(Written by Claude)

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

This PR introduces a crate-level typed Error enum and Result alias in moq-native, replaces runtime anyhow usage with thiserror-based variants, and updates Cargo deps (thiserror at runtime, anyhow moved to dev-dependencies). TLS, backends (quinn/quiche/noq/iroh/websocket), client, server, reconnect, utilities, and examples/CLI/libmoq callers are migrated to return crate::Result with explicit map_err/From conversions; reconnect.closed()/status() callers are updated to propagate or convert errors with ?.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'refactor(moq-native): migrate from anyhow to thiserror' accurately reflects the main change: migrating the moq-native crate from anyhow error handling to thiserror.
Description check	✅ Passed	The description thoroughly explains the refactor, including the migration strategy, error type organization, downstream impacts, compatibility considerations, and test results.
Docstring Coverage	✅ Passed	Docstring coverage is 95.15% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch claude/thirsty-shirley-a366bd

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[kixelated]

IMO don't use Result if it means you have to fully qualify std::result::Result. I'd rather have the opposite; fully-qualify the type alias.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@rs/moq-native/src/error.rs`:
- Around line 17-18: The Directive variant currently wraps
Arc<tracing_subscriber::filter::ParseError> but lacks the #[source] attribute,
so implementors of std::error::Error won't expose the underlying ParseError; add
the #[source] attribute to the Directive enum variant (the
Directive(Arc<tracing_subscriber::filter::ParseError>) entry in the error enum
in error.rs) so Error::source() returns the inner parse error and downstream
diagnostics include the original error details.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7f174d4b-f407-4b01-a748-53b386adcd03

📥 Commits

Reviewing files that changed from the base of the PR and between 98fc447 and d13b893.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (23)

• rs/hang/examples/subscribe.rs
• rs/hang/examples/video.rs
• rs/libmoq/src/api.rs
• rs/libmoq/src/error.rs
• rs/libmoq/src/session.rs
• rs/moq-boy/src/main.rs
• rs/moq-cli/src/client.rs
• rs/moq-cli/src/main.rs
• rs/moq-native/Cargo.toml
• rs/moq-native/examples/clock.rs
• rs/moq-native/src/client.rs
• rs/moq-native/src/error.rs
• rs/moq-native/src/iroh.rs
• rs/moq-native/src/lib.rs
• rs/moq-native/src/log.rs
• rs/moq-native/src/noq.rs
• rs/moq-native/src/quiche.rs
• rs/moq-native/src/quinn.rs
• rs/moq-native/src/reconnect.rs
• rs/moq-native/src/server.rs
• rs/moq-native/src/tls.rs
• rs/moq-native/src/util.rs
• rs/moq-native/src/websocket.rs

🚧 Files skipped from review as they are similar to previous changes (8)

• rs/hang/examples/subscribe.rs
• rs/moq-native/src/log.rs
• rs/moq-native/src/websocket.rs
• rs/moq-native/src/client.rs
• rs/moq-native/src/server.rs
• rs/moq-native/src/tls.rs
• rs/moq-native/src/noq.rs
• rs/moq-native/src/iroh.rs