Fixed typo in definitions of STREAM_HEADER_TRACK and STREAM_HEADER_GROUP #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ajay-s-2502
pushed a commit
to ajay-s-2502/moq-rs
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on my own MOQ implementation and trying to interop, I noticed a typo in how moq-transport defines
STREAM_HEADER_TRACKandSTREAM_HEADER_GROUP: they're basically reversed to how they're defined in the draft. This is an easy fix, but not sure if this could break existing applications based on forks or other libraries that made the same switch to be able to interoperate with this implementation.