Switch from zod v4-mini to regular zod.

[kixelated]

AI gets tripped up on the new v4-mini syntax. One day.

[claude]

Claude finished @kixelated's task —— View job

---

PR Review: Switch from zod v4-mini to regular zod ✅

Reviewed the zod migration for bugs and security issues:

Todo List

• Analyze package.json version changes
• Review new integers.ts file
• Check schema validation changes in catalog files
• Examine publish layer validation updates
• Look for security implications in validation logic

Review Findings

No security issues or bugs found. The migration is clean and actually improves input validation:

Positive changes:

• Better validation: New integers.ts introduces proper bounds checking with u8Schema (0-255) and u53Schema (0 to MAX_SAFE_INTEGER)
• Security improvement: Integer bounds are now enforced where previously they may not have been
• Consistent pattern: u8() used for priority values, u53() for larger numbers like bitrates/sample rates
• Type safety: Branded types prevent mixing different integer categories

Migration quality:

• Package versions properly updated from v4-mini to regular zod ^4.0.0
• All schema files consistently updated to use new integer validation helpers
• No breaking changes to the public API structure

Files reviewed: All 19 changed files including core validation schemas, publish layer, and package configurations.

Recommendation: ✅ Approved - This is a solid migration that enhances input validation security.

[claude]

Claude finished @kixelated's task —— View job

---

PR Review: Switch from zod v4-mini to regular zod ✅

Reviewed the zod migration for bugs and security issues:

Todo List

• Analyze package.json version changes
• Review new integers.ts file
• Check schema validation changes in catalog files
• Examine publish layer validation updates
• Look for security implications in validation logic

Review Findings

No security issues or bugs found. The migration is clean and actually improves input validation:

Positive changes:

• Better validation: New integers.ts introduces proper bounds checking with u8Schema (0-255) and u53Schema (0 to MAX_SAFE_INTEGER)
• Security improvement: Integer bounds are now enforced where previously they may not have been
• Consistent pattern: u8() used for priority values, u53() for larger numbers like bitrates/sample rates
• Type safety: Branded types prevent mixing different integer categories

Migration quality:

• Package versions properly updated from v4-mini to regular zod ^4.0.0
• All schema files consistently updated to use new integer validation helpers
• No breaking changes to the public API structure

Files reviewed: All 19 changed files including core validation schemas, publish layer, and package configurations.

Recommendation: ✅ Approved - This is a solid migration that enhances input validation security.

[cursor]

Bug: Incorrect Catalog Mapping for Display Ratios

The catalog mapping for displayRatioWidth and displayRatioHeight is incorrect. The code attempts to use encoderConfig.displayWidth and encoderConfig.displayHeight, which do not exist on VideoEncoderConfig (it has width and height), resulting in undefined values. Additionally, these catalog fields are semantically defined as ratios of display to coded dimensions, not absolute pixel dimensions.

js/hang/src/publish/video.ts#L366-L378

https://github.com/kixelated/moq/blob/debaae52ce17238bf5f2aabd806a9e9d5fd789e4/js/hang/src/publish/video.ts#L366-L378

Fix in Cursor • Fix in Web

---

BugBot free trial expires on July 29, 2025
Learn more in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎