Use a symbol instead of instanceof for Signal checking.

[kixelated]

Should work across multiple instances of @kixelated/signals

Summary by CodeRabbit

• Bug Fixes

  • Signal instances now work correctly when passed between different versions of the package (cross-version identity and detection improved).

• Chores

  • Bumped package versions: hang → 0.6.1, moq → 0.9.3, signals → 0.8.1.

[coderabbitai]

Walkthrough

This pull request updates package versions: js/hang from 0.5.0 to 0.6.1, js/moq from 0.9.1 to 0.9.3, and js/signals from 0.7.0 to 0.8.1. In js/signals/src/index.ts a new symbol constant SIGNAL_BRAND is added, Signal instances gain a readonly [SIGNAL_BRAND] brand property, and Signal.from is refactored to detect signals via that brand instead of instanceof.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "Use a symbol instead of instanceof for Signal checking" directly reflects the primary substantive change in the changeset. The main modification is in js/signals/src/index.ts, where a new SIGNAL_BRAND symbol is introduced and the Signal.from method is refactored to check for this brand marker instead of using instanceof checks. This enables the Signal checking logic to work correctly across multiple package instances, which aligns with the PR's stated objective. The title is specific, concise, and clearly communicates the core change without unnecessary jargon or vagueness.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch signals-symbol

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7fe131a and cd1a49c.

📒 Files selected for processing (3)

• js/hang/package.json (1 hunks)
• js/moq/package.json (1 hunks)
• js/signals/package.json (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• js/hang/package.json

🚧 Files skipped from review as they are similar to previous changes (2)

• js/moq/package.json
• js/signals/package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Check

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}