Also rename back to --cluster-root

[kixelated]

Summary by CodeRabbit

• Refactor
  • Cluster root configuration parameter renamed from "connect" to "root" across command-line arguments and environment variables.
  • Backward compatibility maintained—previous parameter names remain functional through configuration aliases for seamless upgrades.

[coderabbitai]

Walkthrough

This pull request renames the cluster connection configuration terminology from "connect" to "root" across the codebase. In the cluster configuration, the ClusterConfig field connect is renamed to root with backward compatibility maintained through a serde alias. Command-line argument attributes are updated from cluster-connect to cluster-root, and the environment variable transitions from MOQ_CLUSTER_CONNECT to MOQ_CLUSTER_ROOT. Runtime code is updated to reference the new root field, and the Nix module exports the renamed environment variable while preserving the existing value and conditional logic.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "Also rename back to --cluster-root" directly relates to the main changes in this PR. The changeset systematically renames cluster-related configuration from "connect" terminology to "root" terminology across multiple files: the ClusterConfig field is renamed from connect to root, the command-line argument changes from cluster-connect to cluster-root, and the environment variable changes from MOQ_CLUSTER_CONNECT to MOQ_CLUSTER_ROOT. The title specifically references the --cluster-root argument, which is a key element of these changes, and the word "back" suggests this reverts a previous naming decision. A teammate scanning the history would understand this PR involves renaming cluster configuration back to the "root" terminology.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cluster-root

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

rs/moq-relay/src/cluster.rs (1)

108-110: Consider renaming the pattern variable for clarity.

The pattern variable connect on line 110 is now inconsistent with the field name root. While functionally correct, renaming it to something like root_url would improve readability and reduce potential confusion.

Apply this diff to improve clarity:

-		let root = match self.config.root.clone() {
+		let root = match self.config.root.clone() {
 			// If we're using a root node, then we have to connect to it.
-			Some(connect) if Some(&connect) != self.config.node.as_ref() => connect,
+			Some(root_url) if Some(&root_url) != self.config.node.as_ref() => root_url,
 			// Otherwise, we're the root node so we wait for other nodes to connect to us.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a39c5f7 and 837261b.

📒 Files selected for processing (2)

• rs/moq-relay/src/cluster.rs (3 hunks)
• rs/nix/modules/moq-relay.nix (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

rs/moq-relay/**

📄 CodeRabbit inference engine (CLAUDE.md)

In the CDN/relay (moq-relay), do not include application logic, media codecs, or track-specific details; keep it transport-agnostic.

Files:

• rs/moq-relay/src/cluster.rs

rs/**/src/**/*.rs

📄 CodeRabbit inference engine (CLAUDE.md)

Write Rust tests integrated within source files (unit tests alongside code).

Files:

• rs/moq-relay/src/cluster.rs

🧬 Code graph analysis (1)

rs/moq-relay/src/cluster.rs (1)

rs/moq/src/model/origin.rs (4)

• root (285-310)
• root (425-427)
• root (516-518)
• clone (539-541)

🔇 Additional comments (3)

rs/nix/modules/moq-relay.nix (1)

228-228: LGTM! Environment variable rename aligns with Rust configuration.

The rename from MOQ_CLUSTER_CONNECT to MOQ_CLUSTER_ROOT correctly matches the corresponding change in the Rust ClusterConfig struct, maintaining consistency across the configuration surface.

rs/moq-relay/src/cluster.rs (2)

16-18: Well done! Backward compatibility properly maintained.

The combination of serde alias "connect" and clap alias "cluster-connect" ensures that existing configurations and CLI invocations continue to work while transitioning to the new root terminology.

---

141-141: LGTM! Variable reference correctly updated.

The call to run_remote now correctly passes &root instead of the previous &connect, maintaining consistency with the renamed configuration field.